search

jamesnicolas / yomichan-forvo-server

An audio server for yomichan that scrapes forvo for audio files
33 stars 16 forks source link

update selectors to work with layout changes #9

Closed tomodutch closed 2 years ago

tomodutch commented 2 years ago

Forvo made some changes to their layout which unfortunately broke this addon. This PR contains fixes so both the /word and /search scraping are functional again

cyphar commented 2 years ago

I had a PoC version of this add-on some time ago (before I realised someone else had already made one) and I found that using regex to find the relevant URL data was more resilient to minor layout changes than bs. @jamesnicolas would you be interested in a PR which switches to a regex approach (even as a backup if no URLs are found using bs)?

tomodutch commented 2 years ago

That sounds like a better solution as Forvo may change their layout in the future again

jamesnicolas commented 2 years ago

@cyphar oh that would be really cool! let me merge this one first though to get in the fix asap. sorry everyone for the late response!