search

jamesnw / statstat

Analysis of stats from your thermostat
MIT License
13 stars 4 forks source link

Advise on extending Honeywell Scraper or Creating a second one with inside humidity monitoring #9

Open sn3ak opened 9 years ago

sn3ak commented 9 years ago

My Honeywell supports inside humidity, I would like to add that to the logging/output. Would you prefer I add this support to the existing "Module" or duplicate it and add the support there?

I haven't yet figured out git, so I'd have to submit the patch via comment/email/the like (or just force myself to sit down and look at the git manual)

It looks like Honeywell provides Control.Model.Property.indoorHumiditySensorAvailable as a true/false that we could query and have both in one "module". If your model doesn't have a humidity sensor, can you verify if that option exists? Also "Control.Model.Property.indoorHumidity, 26.0000" is from my unit now.

jamesnw commented 9 years ago

It appears if you don't have a model that has a humidity sensor, indoorHumiditySensorAvailable is false, and indoorHumidity is 128.0000 (an obviously wrong %).

I think it would make sense to add this to the existing module. I'd suggest adding indoorHumiditySensorAvailable and indoorHumidity to the database, saving indoorHumiditySensorAvailable as a Boolean, and perhaps only saving indoorHumidity if indoorHumiditySensorAvailable is true (ie a non-required field).

jamesnw commented 8 years ago

indoorHumidity is now included, but not indoorHumiditySensorAvailable- it would be good to hide indoorHumidity if the sensor is not available.