search

jamesrwhite / minicron

🕰️ Monitor your cron jobs
GNU General Public License v3.0
2.34k stars 154 forks source link

add basic auth support for the client #236

Closed robinjoseph08 closed 7 years ago

robinjoseph08 commented 8 years ago

For those running the minicron server behind a proxy with basic auth enabled, the client needs to be able to pass in the credentials. I tried just making the host config user:pass@host.com, but that didn't work. Since not everyone needs basic auth, I made it optional.

It doesn't look like there are any client tests though, so I couldn't add to it.

@jamesrwhite let me know if there's anything I should add!

jamesrwhite commented 8 years ago

@robinjoseph08 Thanks, I'll review and test this out when I get chance.

jamesrwhite commented 7 years ago

Hey @robinjoseph08, sorry it took me so long to get to this. As per CONTRIBUTING.md I have merged this manually into the develop branch so I'm going to close this PR.