jamesrwhite / minicron

🕰️ Monitor your cron jobs
GNU General Public License v3.0
2.34k stars 154 forks source link

Make `minicron run` API requests async #267

Open saravana91mobiles opened 7 years ago

saravana91mobiles commented 7 years ago

can we stop execution o/p to store in db..

and more over

if we run cron in minicron run 'php test.php'.... then cron script is 2 x slower than php test.php.

any idea how to solve this .

jamesrwhite commented 7 years ago

What do you mean by o/p?

jamesrwhite commented 7 years ago

There will be some overhead with running the cron under minicron as it's sending api requests after each line of output. I'm surprised it's 2x though. This is perhaps something that can be improved in the future by running the api requests in a separate thread or something but I don't believe there is an immediate fix for this right now.

saravana91mobiles commented 7 years ago

o/p -- all execution Output are stored in DB 'job_execution_outputs' .. for a lengthy cron which runs 1 hr ..the output is bigger in size.. so the DB size increases

jamesrwhite commented 7 years ago

At the moment that's not configurable no but I would like to make it so in the future. See: https://github.com/jamesrwhite/minicron/issues/83

jamesrwhite commented 7 years ago

I'll look into the overhead when I get a chance.