jamesrwhite / minicron

🕰️ Monitor your cron jobs
GNU General Public License v3.0
2.34k stars 154 forks source link

Make database port configurable #291

Closed dhuckins closed 6 years ago

dhuckins commented 7 years ago

searched for this but couldn't find anything about it. is it possible to set a port (different from the default) when connecting a mysql or postgres database?

jamesrwhite commented 7 years ago

Currently the port isn't configurable no, bit of an oversight on my part there. It should be relatively easy to add though if you fancy having a go at it.

dhuckins commented 7 years ago

Seems like it, already scoped it out a bit https://github.com/jamesrwhite/minicron/blob/master/lib/minicron.rb#L244

would have to add it to the config no? each database (mysql/postgres) have different default ports maybe put here? https://github.com/jamesrwhite/minicron/blob/master/lib/minicron.rb#L223

thanks