search

jamie-mh / AuthenticatorPro

📱 Two-Factor Authentication (2FA) client for Android + Wear OS
https://authenticatorpro.jmh.me
GNU General Public License v3.0
2.98k stars 198 forks source link

Backups fail when select encrypted and not entering a password. #766

Closed Krojack closed 1 year ago

Krojack commented 1 year ago

Describe the bug Can no longer create backup with no password.

To Reproduce Steps to reproduce the behavior:

  1. Go to backup
  2. Select "Backup to encrypted file"
  3. Don't enter a password.
  4. Get warning message like before and continue.
  5. Message popups up saying "an error has occurred"
  6. See a backup file created but it's zero bytes in size.

Expected behavior A backup file created with data, not an empty file.

App Version 1.19.0

Additional context This happens with auto backup with no password set as well. This worked with previous versions. Maybe some update with the better encryption changes? Also I understand the risk not using a password. For now I set a password for auto backups.

jamie-mh commented 1 year ago

Hi @Krojack ,

Thanks for the report. Yep, this is an oversight on my part. Fixed in 7ae6d58.

Cheers

laduchesneau commented 3 months ago

Hi,

I'm still experiencing this bug, with the same description and same step to reproduce. The only exception is that there is no error displayed when saving. The file saved is still empty.

App version 125.1

Let me know if you prefer I open a new bug report.