jamieduk / mupen64plus

Automatically exported from code.google.com/p/mupen64plus
1 stars 0 forks source link

ROM Properties in GTK GUI Incomplete, Calculate MD5 doesn't work, etc. #66

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
The ROM Properties dialogue in the Gtk GUI is incomplete. Started this 
Issue to call attention to this less often used piece of the GUI. 

The biggest issue is that the Calculate MD5 function is a no-op. We have 
a CalculateMD5 function so this is more of an oversight. 

In the ROM Properties Dialogue a number of uneditable items are 
shown in uneditable Entries. These should either be shown in Lables with 
frames or the ability of the user to put the cursor in the Entry needs to 
be disabled. 

Hitting enter in the Comments Entry should also apply the dialogue 
changes.

Original issue reported on code.google.com by sknau...@wesleyan.edu on 20 Apr 2008 at 9:13

GoogleCodeExporter commented 9 years ago
I see that we're using gtk entries so users can select the MD5 and other info.
for cutting and pasting, such as into a bug report. This is good to have.

Updated the GUI styles and fixed the comment entry issue in Commit 249. 

This brings up why we're not using our CalculateMD5() routine? Is there some 
issue 
with it I am unaware of? Is this for some future planned use? 

I see it loads the ROM into the global ROM memory space. This is bad, since if 
a 
user was running the emulator and wanted to compute the MD5 of a ROM from the 
GUI 
the emulator would crash. 

Thus we have two options:

1) Have computing the MD5 load the rom and prohibit it while the emulator is 
running.
2) Change these functions to load the rom for MD5 computation into a defined 
memory 
space and specify.

I think #2 is the better option but didn't want to change these core functions 
without consulting. 

Original comment by sknau...@wesleyan.edu on 20 Apr 2008 at 8:44

GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago

Original comment by sknau...@wesleyan.edu on 20 Apr 2008 at 8:45

GoogleCodeExporter commented 9 years ago
Going with #2 as we want to be able to use the same rom handling functions with 
the 
general rom cache. Also, the rom loading code needs a good cleanup.

Original comment by sknau...@wesleyan.edu on 9 May 2008 at 12:56

GoogleCodeExporter commented 9 years ago

Original comment by sknau...@wesleyan.edu on 9 May 2008 at 12:56

GoogleCodeExporter commented 9 years ago

Original comment by sknau...@wesleyan.edu on 11 May 2008 at 8:21