search

jamieeeleow / pe

0 stars 0 forks source link

Unable to add different people with the same name #3

Open jamieeeleow opened 1 year ago

jamieeeleow commented 1 year ago

There are some very common names and surnames such as John Tan and they may be two or more such people with the same name. However their contact details will be different since they are different people.

Considering the scenario where I have 2 friends name John Tan that I would like to study with for different modules, I am unable to add both of them into EduMate because they have the same name despite being different people.

An example is shown in the image below:

image.png

I have added James Tan with phone number 88888888 into EduMate and would like to add another friend James Tan with phone number 99999999 into EduMate as well. However I was given the error that This person already exists in the address book. Hence maybe it is worth checking if all the details are the same before throwing an error.

soc-se-bot commented 1 year ago

Team's Response

Although it may occasionally happen, it is very rare for users to add both John Tans into EduMate. Instead, we have allowed the user to type in numbers as well, so we can identify them by number (John Tan 1 vs John Tan 2). The user may also use the person's nicknames in EduMate, so that the user is clearer on who is who. This is intended behaviour.

If we were to allow names to be the same, we would need to refactor quite a lot of our code, as a lot of it is dependent on the names being unique. For example, in the organised meet up panel, we display the names of the participants. If one of the John Tans is in the organised meet up panel, they will be unsure which John Tan it is referring to. As such, there will need to be substantial change if we were to rectify this issue. At the same time, it does not give us much additional value, therefore making it a NotInScope issue.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: I don't think it is rare at all for users to add people of the same name into EduMate. It is very common to have multiple friends with the same name that may share different modules and hence I do think this will hinder the effectiveness of the application if I am unable to both friends in.

## :question: Issue type Team chose [`type.FeatureFlaw`] Originally [`type.FunctionalityBug`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.High`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]