jamoma / JamomaMax

Implementation of Jamoma for Cycling'74 Max:
http://www.jamoma.org
41 stars 9 forks source link

Annoying shortcuts on windows #1015

Open lossius opened 7 years ago

lossius commented 7 years ago

@matcham :

As you may already know, there is an awful bug in Jamoma for windows : when Jamoma package is installed, many default Max key shortcut are disabled (including ctrl-s to save patcher !!)

@theod :

Shortcuts are defined into Jamoma/Max/library/source/JamomaForMax.cpp. here is the code that is enabled currently (I've added some comment to explain each line :

// J -- Jamoma: a new object box with "j." in it

atom_setsym(a+0, SymbolGen("k"));                     // access to the key settings
atom_setsym(a+1, SymbolGen("patcher"));           // in the patcher case
atom_setsym(a+2, SymbolGen("inserttextobj"));    // what to do
atom_setsym(a+3, SymbolGen("j."));                     // for which key

object_method_typed(max, SymbolGen("definecommand"), 4, a, NULL);

First step in order to address this is to identify what shortcuts need to go. @matcham - I'm assigning to you. When you have responded, you can assign back to me, and I'll do the changes to the code.

matcham commented 7 years ago

thanks Trond for doing this proper bug report... I should have done it long time ago...

the shortcuts that do not work in windows when Jamoma package is installed are Ctrl+S (=Save) and Ctrl+shift+S (Save as)

(so this is apparently not a conflict with Jamoma shortcut "J" = create a new jamoma object ...))

bltzr commented 7 years ago

(so this is apparently not a conflict with Jamoma shortcut "J" = create a new jamoma object ...))

which is actually in conflict with « insert a jitter object » that’s why it’s now ‘k' BTW… (which I would like to stay if that doesn’t annoy anyone…)