search

jan-vandenberg / cruddiy

No-code Bootstrap PHP CRUD generator
http://cruddiy.com
GNU Affero General Public License v3.0
253 stars 80 forks source link

Updated Styling for better user Experience. #40

Closed Mayureshp007 closed 2 years ago

Mayureshp007 commented 2 years ago

I have added and removed several Bootstrap classes without changing the original HTML code. Just Removed one
tag though!

After changes this page can look like the following image:

image

Mayureshp007 commented 2 years ago

Columns Page after Changing classes:

image

jan-vandenberg commented 2 years ago

Hi! Thank you so much for these PRs!

Quick question: it seems you made the PRs against an older version of the code, and your branch seems to be a couple versions behind, is there a reason for this?

Mayureshp007 commented 2 years ago

Thank you for your response. I aam new to github and the reason i made it for previous versions is a mistake.

On Tue, Dec 28, 2021, 1:00 AM Jan van den Berg @.***> wrote:

Hi! Thank you so much for these PRs!

Quick question: it seems you made the PRs against an older version of the code, and your branch seems to be a couple versions behind, is there a reason for this?

— Reply to this email directly, view it on GitHub https://github.com/jan-vandenberg/cruddiy/pull/40#issuecomment-1001712720, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACW4D2UNLWP6RWS3JMNJWHDUTC5DZANCNFSM5KZ6H5UQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>

jan-vandenberg commented 2 years ago

No problem, your effort is much appreciated!

Is it possible to make the PR on the latest code base?

Mayureshp007 commented 2 years ago

Sure, as soon as I get some time I will make this happen.

Also, if you have discord we can connect there as well for faster communication.

On Tue, Dec 28, 2021 at 6:40 PM Jan van den Berg @.***> wrote:

No problem, your effort is much appreciated!

Is it possible to make the PR on the latest code base?

— Reply to this email directly, view it on GitHub https://github.com/jan-vandenberg/cruddiy/pull/40#issuecomment-1002098296, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACW4D2T4W6RA3HTMP3HRYPDUTGZKXANCNFSM5KZ6H5UQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>

jan-vandenberg commented 2 years ago

I have had some time to look at it, looks good, so I merged it. Thanks! (PS I am not on Discord)

Mayureshp007 commented 2 years ago

Awesome, thanks!

On Fri, Jan 28, 2022, 4:29 PM Jan van den Berg @.***> wrote:

I have had some time to look at it, looks good, so I merged it. Thanks! (PS I am not on Discord)

— Reply to this email directly, view it on GitHub https://github.com/jan-vandenberg/cruddiy/pull/40#issuecomment-1024104378, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACW4D2UGQKICA7UIRMSKFEDUYJZJLANCNFSM5KZ6H5UQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>