some checkstyle issues

[GoogleCodeExporter]

* License header is seen as code duplication (but, the header MUST be in the 
file, according to the 
style).
* Multiple string literals:  often the same string literals are used, e.g. when 
creating exception 
messages... is it really necessary to make a constant out of it?
* + (string concatenation) on the end of the line or the beginning of the line: 
 does not seem clear 
because both approaches are used
* tabs instead of string:  generates TONS of errors!!! (I think in persistence)
* lots and lots of missing javadoc...

Original issue reported on code.google.com by Tom.Mah...@gmail.com on 25 Jul 2008 at 3:21

[GoogleCodeExporter]

changed checkstyle to have less reclamations about method javadocs; if you have 
a contract, you don't have to 
have a javadoc in our vernacular

Original comment by jandockx on 25 Jul 2008 at 4:00

[GoogleCodeExporter]

* license headers is indeed a problem
* multiple string literals: fixed the warnings in exception vernacular; let's 
see where this goes
* in multi-line expressions, operators should always be at the end of the 
previous line (Java style); changed in 
the style definition
* tabs instead of Strings: I don't understand the issue here; we'll see; in 
general there should be no tabs 
allowed in any text file; use AnyEditTools eclipse plugin to automatically 
convert tabs to 2 spaces on save; it is 
good of checkstyle to report violations
* missing javadoc: fixed style where it needed fixing

so, leftover are:
* license header is seen as code duplication

possibly:
* multiple string literals
* tabs

This is close enough to warant release. We'll see for a couple of days whether 
we can live with this, and then 
go for release. Changed priority to low.

Original comment by jandockx on 25 Jul 2008 at 10:03

• Added labels: Priority-Low, Type-Enhancement
• Removed labels: Priority-Medium, Type-Defect

[GoogleCodeExporter]

See also Issue111

Original comment by jandockx on 27 Jul 2008 at 9:31

[GoogleCodeExporter]

See also Issue112

Original comment by jandockx on 27 Jul 2008 at 9:33