$setting_node undef at the Workbook level

[jandrew]

Submitted via email

Second, a very similar change in LibXML.pm when $setting_node would be undef:

--- DIST/LibXML.pm 2015-08-24 19:49:26.000000000 -0400 +++ SITE_PERL/LibXML.pm 2015-09-14 10:10:20.000000000 -0400 @@ -731,7 +731,7 @@ my ( $list, $sheet_ref, $rel_lookup, $id_lookup ); my $position = 0; my ( $setting_node ) = $dom->getElementsByTagName( 'workbookPr' );

• $self->_set_epoch_year( 1904 ) if $setting_node->getAttribute( 'date1904' );
• $self->_set_epoch_year( 1904 ) if $setting_node and $setting_node->getAttribute( 'date1904' ); for my $sheet ( $dom->getElementsByTagName( 'sheet' ) ){ my $sheet_name = $sheet->getAttribute( 'name' ); push @$list, $sheet_name;

Thanks Todd

[jandrew]

I will try and assign a milestone once I asses the test case

[jandrew]

OK, This is another one that the work of noodling a test file for fail -> pass testing seems more effort than it's worth since the test is just an additional data safe check.

[jandrew]

Closed with release of v0.38.16