janestreet / magic-trace

magic-trace collects and displays high-resolution traces of what a process is doing
https://magic-trace.org
MIT License
4.58k stars 87 forks source link

Please support `tx abrt` perf event #284

Open dmills7 opened 11 months ago

dmills7 commented 11 months ago

Hi, thank you all for creating and maintaining magic-trace!

In one of the applications I've been very keen to profile I am getting this error about an unsupported tx abrt event.

[ Decoding, this takes a while... ]
(monitor.ml Error
  ("BUG: exception raised while parsing perf output. Please report this to https://github.com/janestreet/magic-trace/issues/"
    (exn Not_found)
    (perf_output "17585/17585 45241.495564462: tx abrt 7fffddddc4af [my_function_name] => ... "))
  ("Raised at Base__Error.raise in file \"src/error.ml\", ... )
  ...

Note: I am using magic-trace v1.1.0.

I realised there has been an issue "Support more perf event kinds" https://github.com/janestreet/magic-trace/issues/31 that got closed with:

We support all of these now except for async, tx abrt, vmentry and vmexit. Closing this ticket because these are unlikely to come up in the same context as magic-trace is used (but please open a ticket if you find otherwise).

It would be really awesome if tx abrt was also supported 👍

Thank you