search

janestreet / ppx_sexp_conv

Generation of S-expression conversion functions from type definitions
MIT License
88 stars 17 forks source link

Add a line regarding need to open Sexplib.Conv #16

Closed nojb closed 6 years ago

trefis commented 6 years ago

Hi, Sorry for not getting back to you earlier.

I was about to say "the information you're adding seems redundant with the beginning of the file which already says to open Sexplib.Std". However Std doesn't actually bring these types and converters into scope... So I merged your PR; hopefully we can improve the library and its documentation soon.

Thanks!

nojb commented 6 years ago

No problem, I bumped my ahead against that as well, which is why I proposed to clarify it. Thanks!