Fix gh16

[thatcher]

This is very minimal change without a test, though I'll add a test when you decide how you want to unit tests api changes that arent directly related to rendered output. It basically wraps the relevant code in a try/finally to ensure an unhandled exception doesnt prevent the reset of the original working directory.

[jankatins]

LGTM. If you want to start unittests: as long as a "nosetests" in the basedir works, it's fine. The current output based ones extend unittest.TestCase and I think if I would start it I would go for the pandas unittests model (class with test_methods -> https://github.com/pydata/pandas/blob/master/pandas/tests/test_categorical.py). If you want, you can add such a case, but I will merge this anyway, if you won't be able to add one in the near future. :-)

[thatcher]

I'll find the time to add the unit tests asap but it might take a few days, should be a good opportunity to look at a little of pandas under the hood, thanks for the pointer.

On Mon, May 11, 2015 at 4:00 PM, Jan Schulz notifications@github.com wrote:

LGTM. If you want to start unittests: as long as a "nosetests" in the basedir works, it's fine. The current output based ones extend unittest.TestCase and I think if I would start it I would go for the pandas unittests model (class with test_methods -> https://github.com/pydata/pandas/blob/master/pandas/tests/test_categorical.py). If you want, you can add such a case, but I will merge this anyway, if you won't be able to add one in the near future. :-)

— Reply to this email directly or view it on GitHub https://github.com/JanSchulz/knitpy/pull/25#issuecomment-101031722.

Christopher Thatcher

[jankatins]

Project is dead, sorry! Please consider https://github.com/executablebooks/jupyter-book as a replacement.