Patoshi wrongly identified by block height on testchains

jsarenik commented 2 years ago

Describe the bug

An explorer for Signet is showing Patoshi as the miner just because of the known block height. See https://signet.bitcoinexplorer.org/block-height/3

Such miner identifications could be rather network-specific.

Environment (please complete the following information):

See the Dashboard at https://ex.plebnet.bublina.eu.org/admin/dashboard for any details.

Browser: chrome
Installation Method: source code

Configuration file content

Please include the content from the following files. BE SURE TO MODIFY YOUR CREDENTIALS BEFORE SUBMITTING!!!

bitcoin.conf (not related now after finding the same thing on https://signet.bitcoinexplorer.org/block-height/3)

onlynet=ipv4
onlynet=onion
onlynet=ygg
yggdrasilreachable=1
txindex=1
constatsindex=1
blockfilterindex=1

[signet]
port=12346
bind=[300:5ecb:6b8a:d837::3]:12346
rpcport=11234
signetchallenge=512102ee856c56a5aaadd1656f849bafa4c9dacc86a2878fe546c6189185f842ae2c1851ae
addnode=104.131.10.218
addnode=6megrst422lxzsqvshkqkg6z2zhunywhyrhy3ltezaeyfspfyjdzr3qd.onion
rpcauth=somethinggreathere

Your btc-rpc-explorer environment configuration (either $WORKING_DIR/.env or ~/.config/btc-rpc-explorer.env)

export BTCEXP_HOST=127.0.0.1
export BTCEXP_PORT=3005
export BTCEXP_BITCOIND_HOST=127.0.0.1
export BTCEXP_BITCOIND_PORT=11234
export BTCEXP_BITCOIND_USER=user
export BTCEXP_BITCOIND_PASS=password
export BTCEXP_DEMO=false
export BTCEXP_SLOW_DEVICE_MODE=false
export BTCEXP_NO_RATES=true
export BTCEXP_UI_HOME_PAGE_LATEST_BLOCKS_COUNT=6
export BTCEXP_FILESYSTEM_CACHE_DIR=../../.cache/plebnet

To Reproduce

Steps to reproduce the behavior:

Go to https://signet.bitcoinexplorer.org/block-height/3
See the Miner identified as Patoshi.

jsarenik commented 2 years ago

Works for me with following patch:

diff --git a/app/utils.js b/app/utils.js
index 31e4d6f..4ce4dbf 100644
--- a/app/utils.js
+++ b/app/utils.js
@@ -514,7 +514,7 @@ function identifyMiner(coinbaseTx, blockHeight) {
                                }
                        }

-                       if (miningPoolsConfig.block_heights) {
+                       if (global.activeBlockchain == "main" && miningPoolsConfig.block_heights) {
                                for (var minerName in miningPoolsConfig.block_heights) {
                                        var minerInfo = miningPoolsConfig.block_heights[minerName];
                                        minerInfo.name = minerName;

jsarenik commented 2 years ago

@janoside What do you think about this patch? ^^ Shall I make a PR of it?

jsarenik commented 2 years ago

The explorers already running with the change (and a few unrelated others) are:

janoside / btc-rpc-explorer

Patoshi wrongly identified by block height on testchains #406