janoside / btc-rpc-explorer

Database-free, self-hosted Bitcoin explorer, via RPC to Bitcoin Core.
https://bitcoinexplorer.org
MIT License
1.48k stars 1.11k forks source link

add P2P_V2 flag to servicename abbreviations #580

Closed ExperiBass closed 7 months ago

ExperiBass commented 9 months ago

This pr adds the BIP-324 service name to the abbreviations, so it shows up in the list.

twofaktor commented 6 months ago

I stay connected to a P2P v2 peer:

imagen 291417162-cfa755e8-8223-4933-a56c-cdaa84bbfb17

But I can't see this "P2P_V2" flag on the "Top Service Flags" table in the "Peers" section:

291417296-42194c40-b9b9-4a4c-8b22-9ffaa2cf26a3 imagen

Could you review if this PR is incomplete or what's wrong?

twofaktor commented 3 months ago

Ok, I compiled the latest version using the master branch and now I can see this tag. I hope this feature will be included in the next release. Thanks anyway

imagen