jantap / rsmixer

PulseAudio volume mixer written in rust
MIT License
65 stars 10 forks source link

v0.5.0 doesn't compile with Rust stable #7

Closed guihkx closed 3 years ago

guihkx commented 3 years ago

Will Rust nightly be required to compile rsmixer from now on?

rustc 1.51.0 (2fd73fabe 2021-03-23) cargo 1.51.0 (43b129a20 2021-03-16)

Compilation output:

error[E0554]: `#![feature]` may not be used on the stable release channel
 --> src/main.rs:1:1
  |
1 | #![feature(async_closure)]
  | ^^^^^^^^^^^^^^^^^^^^^^^^^^

error[E0554]: `#![feature]` may not be used on the stable release channel
 --> src/main.rs:2:1
  |
2 | #![feature(btree_retain)]
  | ^^^^^^^^^^^^^^^^^^^^^^^^^

error[E0658]: or-patterns syntax is experimental
  --> src/action_handlers/volume_input_edit.rs:28:22
   |
28 |         KeyCode::Char(x @ ('0' | '1' | '2' | '3' | '4' | '5' | '6' | '7' | '8' | '9')) => {
   |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: see issue #54883 <https://github.com/rust-lang/rust/issues/54883> for more information

warning: unused import: `thiserror::Error`
 --> src/errors.rs:3:5
  |
3 | use thiserror::Error;
  |     ^^^^^^^^^^^^^^^^
  |
  = note: `#[warn(unused_imports)]` on by default

warning: unused import: `pulse::volume`
 --> src/models/state/mod.rs:5:5
  |
5 | use pulse::volume;
  |     ^^^^^^^^^^^^^

error: aborting due to 3 previous errors; 2 warnings emitted

Some errors have detailed explanations: E0554, E0658.
For more information about an error, try `rustc --explain E0554`.
error: could not compile `rsmixer`

To learn more, run the command again with --verbose.
jantap commented 3 years ago

should be fixed in v0.5.1. I'm very sorry for that, happened by mistake

guihkx commented 3 years ago

No worries! :)

guihkx commented 3 years ago

Hi, it's me again. Just wanted to ask you if you've already finished the 0.5.1 release. If you did, can you please push the tag? Tyvm

jantap commented 3 years ago

fuck, i've even changed the version in Cargo.toml, but forgot to push the tag. Done