jantman / vagrant-r10k

UNSUPPORTED - SEEKING MAINTAINER - Vagrant middleware plugin to retrieve puppet modules using r10k.
MIT License
35 stars 12 forks source link

No validation of nil module_path #19

Closed jantman closed 9 years ago

jantman commented 9 years ago

See #18 for an example.

If module_path isn't defined in r10k or puppet config, it ends up being nil, but this isn't caught in either validation or at runtime. The result is that, though the debug logs are clear:

 INFO interface: info: vagrant-r10k: Building the r10k module path with puppet provisioner module_path "". (if module_path is an array, first element is used)
 INFO interface: info: ==> default: vagrant-r10k: Building the r10k module path with puppet provisioner module_path "". (if module_path is an array, first element is used)

The run will fail with an unhelpful error:

/vagrant-r10k-0.2.0/lib/vagrant-r10k/modulegetter.rb:90:in `join': no implicit conversion of nil into String (TypeError)

and then a traceback.

jantman commented 9 years ago

This should have been fixed in #9 / #23.

See: