Set route host to the auto-generated value when clusterRouterBase is set.
The desired manifest for helm should now match the expected host
Additional Information
Now it doesn't actually get Openshift to auto-generate it. It instead utilizes the janus-idp.hostname value which matches the auto-generated value.
This will now require the clusterRouterBase to be properly configured or else the route host will be invalid and users will not be able to access the application via the Route.
Before this change, the route will still be valid if clusterRouterBase is misconfigured and users will still be able to the application, but the backstage config will be incorrect.
Existing or Associated Issue(s)
Fixes #136
Checklist
[x] Chart version bumped in Chart.yaml according to semver.
[ ] Variables are documented in the values.yaml and added to the README.md. The pre-commit utility can be used to generate the necessary content. Use pre-commit run -a to apply changes.
[ ] JSON Schema template updated and re-generated the raw schema via pre-commit hook.
[x] List tests pass for Chart using the Chart Testing tool and the ct lint command.
Needs approval from an approver in each of these files:
- ~~[OWNERS](https://github.com/janus-idp/helm-backstage/blob/main/OWNERS)~~ [rm3l]
Approvers can indicate their approval by writing `/approve` in a comment
Approvers can cancel approval by writing `/approve cancel` in a comment
Description of the change
Set route host to the auto-generated value when
clusterRouterBase
is set. The desired manifest for helm should now match the expected hostAdditional Information
Now it doesn't actually get Openshift to auto-generate it. It instead utilizes the
janus-idp.hostname
value which matches the auto-generated value.This will now require the
clusterRouterBase
to be properly configured or else the route host will be invalid and users will not be able to access the application via the Route.Before this change, the route will still be valid if
clusterRouterBase
is misconfigured and users will still be able to the application, but the backstage config will be incorrect.Existing or Associated Issue(s)
Fixes #136
Checklist
Chart.yaml
according to semver.values.yaml
and added to the README.md. The pre-commit utility can be used to generate the necessary content. Usepre-commit run -a
to apply changes.pre-commit
hook.ct lint
command.