janus-idp / helm-backstage

Helm Chart for Deploying Backstage. This repo is deprecated. Please move to https://github.com/redhat-developer/rhdh-chart
https://redhat-developer.github.io/rhdh-chart/
Apache License 2.0
62 stars 54 forks source link

fix: set route host properly when clusterRouterBase is set #166

Closed Zaperex closed 10 months ago

Zaperex commented 11 months ago

Description of the change

Set route host to the auto-generated value when clusterRouterBase is set. The desired manifest for helm should now match the expected host image

Additional Information

Now it doesn't actually get Openshift to auto-generate it. It instead utilizes the janus-idp.hostname value which matches the auto-generated value.

This will now require the clusterRouterBase to be properly configured or else the route host will be invalid and users will not be able to access the application via the Route.

Before this change, the route will still be valid if clusterRouterBase is misconfigured and users will still be able to the application, but the backstage config will be incorrect.

Existing or Associated Issue(s)

Fixes #136

Checklist

openshift-ci[bot] commented 10 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rm3l

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/janus-idp/helm-backstage/blob/main/OWNERS)~~ [rm3l] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment