search

japacible / commission-me

Platform for commissioners and buyers to connect and finalize sales.
http://commissionme.herokuapp.com/
4 stars 3 forks source link

Determine Popover Content #207

Closed japacible closed 10 years ago

japacible commented 10 years ago

On a user's profile, we currently highlight:

New Requests Pending Accepted Declined Finished Total

... which is all of the possible states of a commission.

I propose that 'new requests' and 'pending' be aggregated, and 'declined'/'total' be removed.

This is something to discuss after commissions is done on Sunday in case the definition of each state is changed.

jbrodhacker commented 10 years ago

I agree that pending doesn't need to be there - as far as I'm aware there is no such status on the server side (even though it was one of the categories I suggested in the initial issue) - but in progress is something that should be on the list because it's past the accepted stage (where a commission would then be waiting for payment), but before the finished stage. Since total is displayed on the page, I don't think that needs to be included either in the popover. However, without declined we should then not include the number of declined commissions in the total displayed on the page either otherwise the math doesn't add up.

quanc commented 10 years ago

How is the status on this?

japacible commented 10 years ago

I'll do this once commissions is completed. It's a trivial change.

japacible commented 10 years ago

Jk, in the interest of time, I'm going to go ahead and make the change to the following. Pending includes new requests.

Pending Accepted Declined Finished

japacible commented 10 years ago

40b6ae6d35f483b08ee204d796e1f80e0d372819