japacible / commission-me

Platform for commissioners and buyers to connect and finalize sales.
http://commissionme.herokuapp.com/
4 stars 3 forks source link

Commission template thumbnails revisited #241

Open kcorman opened 10 years ago

kcorman commented 10 years ago

I know a few days ago Julie took some time to look into commission template thumbnails and discovered it was quite complicated. We agreed that it wasn't a breaking issue so we wouldn't worry about them.

However, I noticed that someone (I think @jbrodhacker ) got image uploads working nicely. I took some of that code and applied it to thumbnails with decent results on a branch.

There's some nuances that were solved in a somewhat hacky way because of the way that we always rebuild the JSON from scratch, so we need to get the image id from the user.

Anyway, I'm not currently planning on pushing this to wip-commissions or master, but if anyone thinks we should (or that this feature is a requirement) we can.

Here's the commit hash

72c6fbc76c