search

jaredhanson / passport

Simple, unobtrusive authentication for Node.js.
https://www.passportjs.org?utm_source=github&utm_medium=referral&utm_campaign=passport&utm_content=about
MIT License
23k stars 1.24k forks source link

Only featured strategies are shown in the website #648

Open darkbasic opened 6 years ago

darkbasic commented 6 years ago

http://www.passportjs.org/packages/

machineghost commented 6 years ago

Other strategies are shown on the site ... it's just that whoever designed the strategy page was clearly focused more on implementing a cool Javascript search/filtering function and than on basic usability. I know usability isn't sexy, but it's still important.

Imagine if you went to Lodash's site, clicked a link for "all Lodash functions", and then only saw map, reduce, and get. That'd be pretty weird right? It wouldn't help if you could search for say debounce, because you wouldn't know that debounce even existed, because the only way to find it is to know that it exists.

That's what Passport's current strategy page is. Even if you only removed the fancy JS-search and just showed a plain HTML list of every strategy, that would be infinitely better usability ... but what would be better still is if the current (cool) search/filtering mechanism remained, but there was also a way to see every strategy. For instance, the way most similar search/filter functionality on the web works is that you start out by seeing everything initially, and then the search/filter whittles down the visible results as you fill it in.

If Passport's strategy page worked that way it would be soooo much useful to every who user who hasn't already memorized Passport's strategy list (ie. most users), and I can't imagine it would even be a very difficult thing to implement. I'd be happy to submit a PR if desired.

phiferd commented 6 years ago

Agreed -- this behavior is terrible.

I came to the issues section to file the same issue. Even after reading the comment from @machineghost it still took me a second to get other strategies to show up. As an example, you can type "passport-j" in the search box and see jwt related strategies. There is also a significant lag when loading the strategies, so you might type something in a see "0 strategies" ... wait 5 seconds or so and something might show up.

It wasn't always like that if I remember correctly.

BenJenkinson commented 6 years ago

I came here to ask this as well. The front page lists "500+ strategies!"

image

And the Features page shows "300+"

image

But click that button and there's only 5?? 😕

image

Where's just a straight-forward list of all the available ones? As someone new to passport, I don't know what strategy I want yet, I want to browse.

BenJenkinson commented 6 years ago

For anyone else who's looking, I found a link to a wiki page of strategies in the comments on issue #675

https://github.com/jaredhanson/passport/wiki/Strategies