jaredly / reason-language-server

A language server for reason, in reason
MIT License
657 stars 84 forks source link

Allow configuring esy path #452

Open bbenne10 opened 4 years ago

bbenne10 commented 4 years ago

Presently, src/analyze/BuildSystem.re (and maybe a few other places, I haven't checked too deeply) does not allow a configurable path to find esy and assumes that esy is in $PATH (or system equivalent) on launch.

This prevents a few different workflows:

I am, admittedly, blissfully unaware of how hard this would be. It looks like BuildSystem.inferPackageManager and BuildSystem.detectFull are the only two places that Error("Couldn't get esy version") is thrown, but I have no idea where those functions are used (or if there're any other non-qualified uses of esy)