jarnedemeulemeester / findroid

Third-party native Jellyfin Android app
GNU General Public License v3.0
2.4k stars 147 forks source link

Make future versions 64 bits instead of 32 #796

Closed Ineocla closed 1 month ago

Ineocla commented 1 month ago

Is your feature request related to a problem? Please describe. With 32 bit apps soon becoming obsolete it doesn't make much sense for findroid to still be a 32 bit app. Especially since it seems the app aims to support fairly modern devices

Describe the solution you'd like Make the future findroid builds 64 bit

Describe alternatives you've considered Keeping the app 32 bit doesn't make much sense unless the maintainers really insist on keeping compatibility with older models

Additional context I stumbled upon this issue when i tried using findroid on my pixel 6a running grapheneos. Everytime i launch the app or start watching a movie or a show a warning message pops saying the app is 32 bit only and that grapheneos will soon drop support for 32 bit apps. I am running the latest findroid version (v0.14.12) from fdroid.

Screenshot_20240725-143836

Jcuhfehl commented 1 month ago

Didn't you install the wrong version? There are also 64 bit releases on the releases page

Ineocla commented 1 month ago

Didn't you install the wrong version? There are also 64 bit releases on the releases page

I installed the only availble version on izzyondroid Screenshot_20240725-153735 (For context i use neostore as my fdroid frontend)

Jcuhfehl commented 1 month ago

The one on izzyondroid is the 32 bit version. There already is a 64 bit version

jarnedemeulemeester commented 1 month ago

I may ask IzzySoft (maintainer of IzzyOnDroid) to switch out the armv7 (32-bit) build for the armv8 (64-bit) one.

However for now if you want to easily download Findroid without using the Google Play store I recommend Obtanium. Just add Findroid via it's GitHub URL (or search)

lbrunkho commented 1 day ago

@obfusk, it looks like you were the one to set up the Izzyondroid repo? This app only ships with a 32-bit apk there. Do you think we could get the 64-bit apk from the github releases there as well?

obfusk commented 1 day ago

IzzyOnDroid can only provide one APK per version. But developers can ask us to switch to 64-bit if that's preferred.

I'm responsible for our Reproducible Builds tooling; for changes to the repo itself, you'll want to ask @IzzySoft :)

IzzySoft commented 1 day ago

@jarnedemeulemeester I fully agree, you may ask :zany_face: So do you want to ask (as you did not include the @ sign and I got no ping)? Findroid's 32bit version is already beyond the per-app size limit at IoD (limit: 30 MB, APK: 33.8 MB), the 64bit one is even a little bigger (35.8 MB). So I'd ask you in return to keep an eye on APK size :wink:

Things to keep in mind: with very few exceptions (I know of only a single device), all 64bit devices do support 32bit APKs. But not a single 32bit device (yes, there are still some in use – and IzzyOnDroid wants to support "longevity" of devices, to avoid e-waste wherever possible) can support 64bit APKs. So switching to 64bit will drop support for some.

lbrunkho commented 1 day ago

@IzzySoft just a heads up, GrapheneOS has disabled 32-bit apps at the kernel level. I know this is a corner case, just something to keep in mind.

IzzySoft commented 1 day ago

@lbrunkho GOS has the "always latest from Google" approach. IoD has the "keep your devices useful and long-living" approach. A matter of choice, still: if you want to go with GOS, there's always Obtainium. Or GOS' own store, Accrescent. There are some security arguments for 64bit, but GOS going 64bit only is no argument for IoD to drop support for 32bit, sorry – and it also just affects a few devices (including the single 64bit-only device known to me).