search

jarro2783 / cxxopts

Lightweight C++ command line option parser
MIT License
4.25k stars 590 forks source link

Fixes #345, fixes #346: Exception code tweaks #347

Closed eyalroz closed 2 years ago

eyalroz commented 2 years ago

This puts exceptions in their own sub-namespace and renames some of them accordingly.

Note that I think there might be an over-abundance of exception classes in the library, but so be it...

This change is Reviewable

jarro2783 commented 2 years ago

This is good, but I think it needs rebasing after the namespace fixes.

eyalroz commented 2 years ago

Yes, I'll take care of that soon.

eyalroz commented 2 years ago

@jarro2783 : Done, and also had to make a few more changes regarding namespace indentation which slipped by me in PR #350.

eyalroz commented 2 years ago

@jarro2783 : After this, let's go for #349 .

eyalroz commented 2 years ago

So, somehow after the merge, the exceptions namespace itself is indented. Will submit another PR.