Building on MacOS fails

hillmich commented 2 years ago

As of now, MacOS still fails (PR #368 did not fix it, sorry I messed that up).

I forked the repo and made quite a lot of changes trying to make std::isblank work on hillmich/cxxopts. The main change is to replace std::isblank by explicitly checking for space and tab as the standard dictates for the C locale. This fork also includes

CI on MacOS and Windows
Assume header regexp is always there since cxxopts requires c++11 or higher (and eliminate a large chunk of code)
Remove some unused headers
Get around requiring cstring
Add std:: to instances of size_t

@jarro2783 are you interested in these changes and would you accept them as PR?

jarro2783 commented 2 years ago

sounds good, make a PR and I'll take a look.

VictorEijkhout commented 2 years ago

Progress on this? I'm in need of this fix. EDIT 3.0.0 release compiles correctly, so I'm good for now.

jarro2783 commented 2 years ago

Sorry I got distracted by something else, I'll follow up on that PR.

jarro2783 / cxxopts

Building on MacOS fails #369