jarun / nnn

n³ The unorthodox terminal file manager
BSD 2-Clause "Simplified" License
18.51k stars 743 forks source link

Misleading typo in the wiki #1871

Closed zhangxiaoxing closed 2 months ago

zhangxiaoxing commented 2 months ago

The wiki Usage - Program options section, foot notes No. 4 says

"The keys for option -T are apparent disk usage / disk usage / extension / revision / size / time / version. Capitalize to reverse (except r)".

From the following excerpt from the source code, I'm fairly certain the "revision" should actually be "reverse". This is causing confusions, I guess we should correct it.

case 'e': /* File extension */
    cfg.extnorder ^= 1;
    cfg.sizeorder = 0;
    cfg.timeorder = 0;
    cfg.apparentsz = 0;
    cfg.blkorder = 0;
    cfg.reverse = 0;
    entrycmpfn = &entrycmp;
    break;
case 'r': /* Reverse sort */
    cfg.reverse ^= 1;
    entrycmpfn = cfg.reverse ? &reventrycmp : &entrycmp;
    break;
case 's': /* File size */
    cfg.sizeorder ^= 1;
    cfg.timeorder = 0;
    cfg.apparentsz = 0;
    cfg.blkorder = 0;
    cfg.extnorder = 0;
    cfg.reverse = 0;
    entrycmpfn = &entrycmp;
    break;
N-R-K commented 2 months ago

Thanks, fixed.