search

jasondcamp / pyway

A Flyway like migration manager written in python.
GNU General Public License v3.0
24 stars 12 forks source link

Add tests for postgres #44

Closed jasondcamp closed 6 months ago

jasondcamp commented 7 months ago

We missed an issue with SQL in the postgres factory, because we're not testing against postgres. Work on this.

walnutist commented 7 months ago

I can see by default the Config obj is instantiated with assumed postgres connection info, if there is no env_vars, no conf, whatsoever. This is not expected behavior for user, the proper way might be to raise empty value error, or even better, a validation error message.

jasondcamp commented 6 months ago

Added postgres integration tests, will look into the suggestion above for default config behavior

jasondcamp commented 6 months ago

Cleaned up the ConfigFile defaults in 0.3.25