search

jasongin / noble-uwp

Noble (Node.js Bluetooth LE) with Windows 10 UWP bindings
MIT License
83 stars 45 forks source link

Expose service data on advertisements (this is probably just a hack) #22

Closed smurf667 closed 7 years ago

smurf667 commented 7 years ago

Hello,

just wanted to let you know what I did to expose service data (the one I needed in a proof of concept) for advertisement messages. I realise it is hackish and am totally okay with the pull request getting rejected. I thought I'll let you know since the current master says "TODO" for service data...

Regards, Jan

jasongin commented 7 years ago

Thanks! I will take a look and try it out.

jasongin commented 7 years ago

Sorry for the lack of updates, I haven't forgotten about this. I'm incorporating this change into some other improvements I'm working on related to parsing advertisements.

smurf667 commented 7 years ago

No problem! Thanks!

On Jul 26, 2017 19:28, "Jason Ginchereau" notifications@github.com wrote:

Sorry for the lack of updates, I haven't forgotten about this. I'm incorporating this change into some other improvements I'm working on related to parsing advertisements.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/jasongin/noble-uwp/pull/22#issuecomment-318125196, or mute the thread https://github.com/notifications/unsubscribe-auth/AK8__NfopZRYIjMsfhqwZS_5aA2qqC4-ks5sR3dYgaJpZM4OUEY- .

jasongin commented 7 years ago

This is done in 0.5, as part of some other changes. I didn't include this change directly because I ended up refactoring a bit.

Let me know if it works for you. The spec was a little difficult to understand, so maybe not every kind of service data is supported. But at least the part you implemented is there.