Fix descriptor bug. - Githubissues

jasongin / noble-uwp

Noble (Node.js Bluetooth LE) with Windows 10 UWP bindings

MIT License

83 stars 45 forks source link

Fix descriptor bug. #58

Closed itome closed 6 years ago

itome commented 6 years ago

I realized that descriptor have some bugs. [Fixed bug]

descriptor uuids are not correct.(Fixed in b817205) noble returns descriptor uuid = "XXXX" but noble-uwp returns uuid = "{YYYYY-XXXX-YYYYY-YYYYY-YYYYY}"
characteristic returned from promise incorrectory named service(Fixed in bf93e9c)
descriptor's read and write event name are incorrect. (Fixed in 37bb011) noble emit valueWrite event when descriptor wrote. but noble-uwp emit writeValue. Sorry for my poor english. Feel free to ask me about change.

itome commented 6 years ago

@jasongin Any progress here?

jasongin commented 6 years ago

Sorry I overlooked this PR before, I was super busy at the time and was not working on bluetooth things.

These are some good fixes, thanks!