search

jasonjmcghee / rem

An open source approach to locally record and enable searching everything you view on your Mac.
https://rem.ing
MIT License
2.28k stars 68 forks source link

Search filters (by app, time, etc.) #46

Open jasonjmcghee opened 9 months ago

jasonjmcghee commented 9 months ago

We should come up with a good ui to allow for filtering based on different criteria

caetano-dev commented 8 months ago

Hello, @jasonjmcghee

I've added a feature in my fork that lets users filter the applications they want to search for. I don't know if it is exactly how you want to implement it, but here is a demo of it.

If this is something you think we could add to Rem, just let me know and I'll open a PR!

https://github.com/jasonjmcghee/rem/assets/55260356/8187a36e-a781-4360-b8a6-68916e9763ec

jasonjmcghee commented 8 months ago

Definitely cool. The one drawback would be you can't search for literally "!", but I think it's well worth the tradeoff (likely very rare case).

Most of the logic can also get reused if someone wants to add a dropdown or otherwise visual experience for filtering.

You should open a PR!

Unrelated - wow that flashing on search is horrible (sorry!). If you feel like being even more awesome, you could take a crack at not clearing results (thumbnails) until the new ones are available. this would make it a wildly more fluid experience.

caetano-dev commented 8 months ago

Sure! I opened the PR.

I'll take a look at this flashing problem and see if I can figure out how solve it.