search

jasonlewis / basset

A better asset management package for Laravel.
http://jasonlewis.me/code/basset
240 stars 76 forks source link

Fix/fsclean glob #142

Closed ghost closed 11 years ago

ghost commented 11 years ago

Check if result of glob is array / not-empty / not === false

codegefluester commented 11 years ago

:+1:

jasonlewis commented 11 years ago

According to PHP.net it returns "an empty array if no file matched or FALSE on error." Wouldn't it be better just to ensure that the result is an array, if not, return, otherwise run the loop.

vanadium23 commented 11 years ago

When this request will be merged, because pull it on every devs comp doesn't have any pleasure)

jasonlewis commented 11 years ago

I'm not sure why so many checks are required. Care to fill me in?

ghost commented 11 years ago

removed the unnecessary checks. can you pull it ?

vanadium23 commented 11 years ago

Thanks!