search

jasonlewis / basset

A better asset management package for Laravel.
http://jasonlewis.me/code/basset
240 stars 76 forks source link

JsMin logging all over the place #144

Closed Anahkiasen closed 11 years ago

Anahkiasen commented 11 years ago

I keep getting warning thrown by the JsMin filter that – although most of the time seem logical – kind of fill up my logs with unecessary warnings :

[2013-05-30 08:37:46] log.ERROR: "JsMinFilter" will not be applied to asset "components/icomoon/site/style.css" due to failing requirements or invalid filter name. [] []
[2013-05-30 08:37:47] log.ERROR: "JsMinFilter" will not be applied to asset "components/icomoon/site/style.css" due to failing requirements or invalid filter name. [] []
[2013-05-30 08:38:35] log.ERROR: "CssMinFilter" will not be applied to asset "components/icomoon/site/style.css" due to failing requirements or invalid filter name. [] []
[2013-05-30 08:38:35] log.ERROR: "JsMinFilter" will not be applied to asset "components/icomoon/site/style.css" due to failing requirements or invalid filter name. [] []
[2013-05-30 08:38:35] log.ERROR: "CssMinFilter" will not be applied to asset "components/icomoon/site/style.css" due to failing requirements or invalid filter name. [] []
[2013-05-30 08:38:35] log.ERROR: "JsMinFilter" will not be applied to asset "components/icomoon/site/style.css" due to failing requirements or invalid filter name. [] []
[2013-05-30 08:38:35] log.ERROR: "CssMinFilter" will not be applied to asset "app/js/dynamic-loading.js" due to failing requirements or invalid filter name. [] []
[2013-05-30 08:38:35] log.ERROR: "JsMinFilter" will not be applied to asset "app/js/dynamic-loading.js" due to failing requirements or invalid filter name. [] []
[2013-05-30 08:38:35] log.ERROR: "CssMinFilter" will not be applied to asset "app/js/dynamic-loading.js" due to failing requirements or invalid filter name. [] []

What he calls "failing requirements" is either trying to apply the JsMin filter to a CSS file (although I specified ->whenAssetIs('*.js') on the Js filter) or simply me not being in production which is a requirement too. I don't think it should throw warnings in the latter case.

subdesign commented 11 years ago

Same problem here

jasonlewis commented 11 years ago

Yeah that makes sense. I didn't even consider that. Will push a fix shortly.