search

jasonlewis / basset

A better asset management package for Laravel.
http://jasonlewis.me/code/basset
240 stars 76 forks source link

[Patch] duplicate assets on windows #173

Closed radmen closed 9 years ago

radmen commented 11 years ago

This PR fixes #135.

Quick, and "dirty" trick to normalize assets paths. I couldn't use realpath() for this purpose, so decided to replace \ with unix directory separator /.

Also during this time one thing happened. My changes from PR #140 were somehow reverted.. I've put them back, because without it occurred some problems with assets order.

Unit test for that would be useful, but for now I don't have enough time to write it :(

radmen commented 11 years ago

@jasonlewis ping

jasonlewis commented 11 years ago

Sorry @radmen, haven't had time to work on Basset. Things are sort of on hold at the moment.

radmen commented 11 years ago

@jasonlewis okie. Gimme some feedback when you get back to the project :)