jasonw4331 / MyPlot

Plot and protection plugin for PocketMine-MP
https://discord.gg/Qqcpp9Q
MIT License
101 stars 89 forks source link

Add support for BedrockEconomy + Capital #468

Open MrBlasyMSK opened 2 years ago

MrBlasyMSK commented 2 years ago

I wanted to know if it is possible to add support for BedrockEconomy and Capital since that is what is now mostly being used for API 4 and they are going to be updated with improvements and bug fixes (not like EconomyAPI).

jasonw4331 commented 2 years ago

I have support for Capital on the libasynql branch. It's still very work-in-progress. It's unlikely I will support both due to the different async architectures they use

MrBlasyMSK commented 2 years ago

I have support for Capital on the libasynql branch. It's still very work-in-progress. unfortunately it's impossible to support both due to the different async architectures they use

Is there no way to add BedrockEconomy? I say this because most plugins are using that or EconomyAPI, here are some examples:

LuckyPlayer by MintoD CustomShopUI by AlexPads ChestShop by Muqsit etc...

And it would be annoying for most people to have to change a complete Economy plugin for a different one and in which there are almost no existing plugins that have Capital support.

jasonw4331 commented 2 years ago

The asynchronous architecture I'm using is based on php's Generator class, but BedrockEconomy's is based on closures and threads, which makes it difficult to synchronize the result to be passed back into the first async chain. It's probably possible, but ridiculously over complicated

MrBlasyMSK commented 2 years ago

Well after all you are the one who makes the plugin so I don't want to pressure you to do anything, I just hope that in the future you plan to add it.

If you want to close this issue

BoyKage commented 2 years ago

It would be nice to add it to BedrockEconomy because I also use it, and it would be annoying if I had to change the server's Economy