[Bug]: Flag Supported Correlations doesn't work in Bayesian Correlation Tables when "show BFs" is not enabled

[jack-ptrs]

JASP Version

Others

Commit ID

No response

JASP Module

Regression

What analysis are you seeing the problem on?

Bayesian Correlation

What OS are you seeing the problem on?

macOS Silicon

Bug Description

Supported correlations are not flagged anymore when I do not also select report Bayes factors in the correlation table. Underneath the table the notes appear as if supported correlations are flagged (i.e., *BF10>10 etc.), but then they are not actually flagged in the table, which is misleading as it then seems that none of them are "supported".

When selecting Flag supported correlations:

When selecting supported correlations and report BFs:

Expected Behaviour

Correlations should be flagged in line with notes underneath the correlation table.

Steps to Reproduce

1. Regression module 2.Bayesian Correlation
2. Select flag supported correlations ...

Log (if any)

No response

Final Checklist

• [X] I have included a screenshot showcasing the issue, if possible.
• [ ] I have included a JASP file (zipped) or data file that causes the crash/bug, if applicable.
• [X] I have accurately described the bug, and steps to reproduce it.

[github-actions[bot]]

@jack-ptrs, thanks for taking the time to create this issue. If possible (and applicable), please upload to the issue website (https://github.com/jasp-stats/jasp-issues/issues/2259) a screenshot showcasing the problem, and/or a compressed (zipped) .jasp file or the data file that causes the issue. If you would prefer not to make your data publicly available, you can send your file(s) directly to us, issues@jasp-stats.org

[tomtomme]

@jack-ptrs @Kucharssim Confirmed with jasp 0.19 beta from 23. may 2024 I guess this is a kind of feature and not a bug, since one should not just report the levels but exact BFs.

But, this is still confusing and easily fixed by making "flag supported correlations" button only clickable if "Report Bayes factor" is clicked. OR by making both checkboxes really work independent of each other. Therefore BF would need to be calculated in the background even if not ticked explicitely