search

jasperla / openbsd-wip

OpenBSD work in progress ports
http://www.openbsd.org/
267 stars 88 forks source link

Add port net/py-python-socks which is needed for electrum #154

Closed kokokodak closed 1 year ago

kokokodak commented 1 year ago

This is port of one of the dependencies of electrum.

sthen commented 1 year ago

Please don't use MODPY_SETUPTOOLS for new ports, use MODPY_PYBUILD (check which build system is used - if there's no pyproject.toml or pyproject doesn't specify the build system then it will be MODPY_PYBUILD=setuptools; more recently updated software might use others e.g. flit_core hatchling poetry-core).

kokokodak commented 1 year ago

Thanks for the comment. I've fixed the issue in all three new python ports that I am submitting here. Upon changing MODPY_SETUPTOOLS to MODPY_PYBUILD, I needed to regenerate PLIST, I believe that's expected. Also I've slightly fixed the formatting (space before '=').

sthen commented 1 year ago

thanks, I'll merge them. it doesn't particularly matter which style of spacing around = is used as long as it's consistent.