search

javascriptdata / danfojs

Danfo.js is an open source, JavaScript library providing high performance, intuitive, and easy to use data structures for manipulating and processing structured data.
https://danfo.jsdata.org/
MIT License
4.81k stars 209 forks source link

Cell Styles Override Header Styles in Plotly Tables #34

Closed robertwalsh0 closed 4 years ago

robertwalsh0 commented 4 years ago

I've found that, when plotting tables, header_style will be overwritten by cell_style

As you can see in the image below, the headers should be #333 but instead are overridden by the cell styles red.

Link to codepen: https://codepen.io/robwalsh0/pen/GRqRXOK

Screen Shot 2020-10-07 at 7 55 05 PM
risenW commented 4 years ago

Thanks for raising this issue. I was able to reproduce it. I'll work on this ASAP

robertwalsh0 commented 4 years ago

@risenW Thank you! I've also been unable to change the widths of columns by following the instructions listed in your docs. Could you also verify that this is possible, and if so, document how that works?

robertwalsh0 commented 4 years ago

@risenW made a pull request that fixes the issue with the header and cells style conflicts: https://github.com/opensource9ja/danfojs/pull/38

risenW commented 4 years ago

@robertwalsh0 Thanks for this fix! I'm merging now.