search

javaterminal / cloudterm

Cloud Web Terminal Emulator. Opens your terminal to Web.
MIT License
78 stars 37 forks source link

remove `pty.waitFor()` && add session close handle #7

Closed Xarrow closed 4 years ago

Xarrow commented 4 years ago

  1. pty.waitFor() just hold process wait util process is terminated, just like java.lang.Process. So it's not unnecessary to use thread keep process wait in web application. Reference at https://github.com/JetBrains/pty4j/issues/87#event-3457185561

  2. Add method of onTerminalClose to handle the WebSocket session which is in not open state and release pty process.

Xarrow commented 4 years ago

@rahmanusta it fixed.

rahmanusta commented 4 years ago

Thanks @Xarrow , I appreciate your contributions