search

jaybaird / python-bloomfilter

Scalable Bloom Filter implemented in Python
MIT License
1.62k stars 330 forks source link

pytest runs files named test_* #20

Open tivvit opened 8 years ago

tivvit commented 8 years ago

Current implementation is not testing at all :wink: https://travis-ci.org/jaybaird/python-bloomfilter/jobs/89314785

============================= test session starts ==============================
platform linux2 -- Python 2.6.9 -- py-1.4.26 -- pytest-2.6.4
collected 0 items
tivvit commented 8 years ago

after fix: https://travis-ci.org/jaybaird/python-bloomfilter/jobs/105753930

============================= test session starts ==============================
platform linux3 -- Python 2.6.9, pytest-2.8.5, py-1.4.31, pluggy-0.3.1
rootdir: /home/travis/build/jaybaird/python-bloomfilter, inifile: 
collected 7 items 
pybloom/test_pybloom.py .......
================= 7 passed, 1 pytest-warnings in 1.09 seconds ==================
joseph-fox commented 8 years ago

You need to change the (test) file name on https://github.com/joseph-fox/python-bloomfilter/blob/master/tox.ini#L5 too.

tivvit commented 8 years ago

fixed, thanks for noticing

joseph-fox commented 8 years ago

I made a PR months ago, and there has never been a reply or a comment. I am wondering if you are happy to make a PR against my master, so we can continue maintaining this project.

tivvit commented 8 years ago

I have no problem with that, but I would like to ask if you have any idea how to get your fork to pip?

joseph-fox commented 8 years ago

The submission of pypi isn't complicated. I will register an account and look at setup.py, setup.cfg in the next few days.

tivvit commented 8 years ago

I have published some packages to pip, but I am afraid that we will have to publish our version under different name.

joseph-fox commented 8 years ago

Sure. :100: no problem.

joseph-fox commented 8 years ago

It is on Pypi now. https://pypi.python.org/pypi/pybloom_live