search

jayugg / BalancedThirst

Add thirst to Vintage Story!
http://mods.vintagestory.at/balancedthirst
0 stars 0 forks source link

Placing raw kettle crashes the game. #1

Closed Shadeloid closed 5 months ago

Shadeloid commented 5 months ago

When i was placing the raw kettle in the pit kiln, the game crashed. Version: 1.19.8

server-main.txt client-main.txt

jacopouggeri commented 5 months ago

Did you just place a raw kettle, then add grass? Because when I try to do it nothing happens. The method that crashes is also very simple, I'll add some extra null checks but I can't do much else without seeing it in action.

SpearAndFang commented 5 months ago

"System.NullReferenceException: Object reference not set to an instance of an object. at BalancedThirst.HarmonyPatches.CollObj.CollectibleObject_tryEatBegin_Patch.Postfix"

maybe they accidently tried to drink from the raw kettle?

Shadeloid commented 5 months ago

No, i just placed the kettle on the grass to make a pit, but the moment i used ctrl+ right click to place it, it crashed imedietly.

jacopouggeri commented 5 months ago

Does it still crash with the new version? I got 3 reports of this but I was never able to replicate it. I added some extra null checks in the patch that might solve the issue, although the null exception was at the end of the patch because, correctly, you cannot drink a raw kettle, so the method should return immediately.

Shadeloid commented 5 months ago

It's fixed now. I didn't crash anymore.