Form Layouts - change row template based on field type

[marshallds]

I'm really liking floppyforms but there's one thing I haven't figured out, even after reading the source. I want to be able to use a generic form layout that can use different row templates for different widget types (or have type in the context for the row template to do conditionals). The use case for this is where the label's relationship to the field might be different.

e.g. a BooleanField should generate the following row code (bootstrap style)

<div class="controls">
    <label class="checkbox"><input type="checkbox"> Remember me</label>
</div>

instead of

<label class="control-label">Remember me:</label>
<div class="controls">
    <input type="checkbox">
</div>

which would otherwise be fine for a text input.

If I missed something give me a clue and I'll write up a pull request for the documentation when I've got it worked out. Otherwise I would like to make a feature request.

[nferrari]

+1. Did not figure out how to test a field type in the {% block row %} scope.

[gregmuellegger]

Hi, yes it's true there is no way at the moment to configure the formrow config based on the given widget types.

The problem in that regard is, that a {% formrow %} tag can take multiple fields like:

{% formrow form.username form.password %}

And if both fields are configured to have a different row template, what shall the formrow do then? So I think we still should make it possible. We could have something like this:

{% formconfig row using "custom_row.html" for form.username form.password %}

This would than only match {% formrow form.username form.password %} but not {% formrow form.username %} nor {% formrow form.password %}. Here an example on how to use it on a widgettype only:

{% formconfig row using "custom_row.html" for "DateInput" %}

Which would match: {% formrow form.birthday %} But not: {% formrow form.birthday form.day_of_marriage %} (So it would only match a row with one DateInput, but not a row with two DateInputs.)

What do you think? Does this make sense in your eyes?

[poswald]

That may work but I think the problem is that the field that you are given in the formrow doesn't seem to have a type if you try to implement your own switching in the loop like:

{% load floppyforms %}{% block row %}{% for field in fields %}
{% if field.type == 'checkbox' %}
...
{% else %}
...
{% endif %}
{% endfor %}{% endblock %}

Having multiple fields passed in isn't an issue if you can test them inside the loop. I don't see how to get the type associated with that field though because it seems to be a django field at that point.

To do Bootstrap properly you (unfortunately) have to specify different html and need to know the underlying type at the row level. Having to specify using "custom_row.html" each time is a bit annoying as it's not really 'custom'. Every bootstrap checkbox should be rendered with that html... it's not really something you should have to remember to specify. The row template (or tag) should take care of it.