search

jazzband / django-fsm-log

Automatic logging for Django FSM
https://django-fsm-log.readthedocs.io/en/latest/
MIT License
241 stars 78 forks source link

get_state_display will work with FSMIntegerField #63

Closed hggh closed 6 years ago

hggh commented 6 years ago

get_state_display has to convert the string into a integer before access the dict of the fieldchoices

codecov-io commented 6 years ago

Codecov Report

Merging #63 into master will increase coverage by 0.29%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #63      +/-   ##
==========================================
+ Coverage   94.38%   94.68%   +0.29%     
==========================================
  Files          19       19              
  Lines         356      376      +20     
==========================================
+ Hits          336      356      +20     
  Misses         20       20
Impacted Files Coverage Δ
tests/test_model.py 100% <100%> (ø) :arrow_up:
tests/conftest.py 100% <100%> (ø) :arrow_up:
django_fsm_log/models.py 100% <100%> (ø) :arrow_up:
tests/models.py 93.75% <100%> (+2.44%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 76b9fe8...23a7a54. Read the comment docs.

hggh commented 6 years ago

@ticosax I have updated my PR and removed the marker stuff

ticosax commented 6 years ago

thank you @hggh !