Codecov Report

Merging #103 (b158c6b) into master (57b3d4a) will increase coverage by 0.69%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #103      +/-   ##
==========================================
+ Coverage   64.00%   64.70%   +0.69%     
==========================================
  Files           4        4              
  Lines         439      442       +3     
  Branches      127      127              
==========================================
+ Hits          281      286       +5     
+ Misses        116      115       -1     
+ Partials       42       41       -1

Impacted Files	Coverage Δ
django_redshift_backend/base.py	`63.99% <100.00%> (+0.75%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 57b3d4a...b158c6b. Read the comment docs.

ArthurNRL commented 2 years ago

I can do that this weekend

ArthurNRL commented 2 years ago

Hey, I fixed the lint issue, but I'm having trouble setting the test case up. I would need to run migrations on a db since model.add() needs the model to be saved on the db, but none of the tests in there, other than the migration ones, actually interact with the db.

shimizukawa commented 3 days ago

I'm sorry I haven't been able to reply for so long. I would like to include this request/PR on #167.

jazzband / django-redshift-backend

Removes the unsupported "ON CONFLICT DO NOTHING" clause #103

Feature or Bugfix

Purpose

Detail

Relates

Codecov Report