jazzband / django-redshift-backend

Redshift database backend for Django
Apache License 2.0
82 stars 47 forks source link

add distinct on support #104

Open delta575 opened 2 years ago

delta575 commented 2 years ago

Subject: add distinct on support

Feature or Bugfix

Purpose

Detail

Relates

codecov[bot] commented 2 years ago

Codecov Report

Merging #104 (8d7f03f) into master (57b3d4a) will decrease coverage by 2.56%. The diff coverage is 57.50%.

:exclamation: Current head 8d7f03f differs from pull request most recent head 35a3861. Consider uploading reports for the commit 35a3861 to get more accurate results

@@            Coverage Diff             @@
##           master     #104      +/-   ##
==========================================
- Coverage   64.00%   61.44%   -2.57%     
==========================================
  Files           4        5       +1     
  Lines         439      555     +116     
  Branches      127      164      +37     
==========================================
+ Hits          281      341      +60     
- Misses        116      158      +42     
- Partials       42       56      +14     
Impacted Files Coverage Δ
django_redshift_backend/compiler.py 52.83% <52.83%> (ø)
django_redshift_backend/base.py 62.67% <92.85%> (-0.56%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 57b3d4a...35a3861. Read the comment docs.

shimizukawa commented 3 days ago

I'm sorry I haven't been able to reply for so long. I would like to include this request/PR on #167.