jpaniagualaconich commented 2 years ago

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

jpaniagualaconich commented 2 years ago

only now i realise example has its own base template 😅️

codecov[bot] commented 2 years ago

Codecov Report

Merging #551 (7faead3) into master (c086b7f) will increase coverage by 10.52%. The diff coverage is n/a.

@@             Coverage Diff             @@
##           master     #551       +/-   ##
===========================================
+ Coverage   87.63%   98.15%   +10.52%     
===========================================
  Files          65       65               
  Lines        2862     2932       +70     
  Branches      261      290       +29     
===========================================
+ Hits         2508     2878      +370     
+ Misses        337       30      -307     
- Partials       17       24        +7

Impacted Files	Coverage Δ
tests/test_admin.py	`100.00% <0.00%> (ø)`
tests/test_email.py	`100.00% <0.00%> (ø)`
tests/test_utils.py	`100.00% <0.00%> (ø)`
tests/test_yubikey.py	`100.00% <0.00%> (ø)`
tests/test_gateways.py	`100.00% <0.00%> (ø)`
tests/test_views_login.py	`100.00% <0.00%> (ø)`
tests/test_views_phone.py	`100.00% <0.00%> (ø)`
tests/test_views_setup.py	`100.00% <0.00%> (ø)`
tests/test_views_mixins.py	`100.00% <0.00%> (ø)`
tests/test_views_qrcode.py	`100.00% <0.00%> (ø)`
... and 18 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

jpaniagualaconich commented 1 year ago

@claudep @moggers87 there's also this one that I overlooked.