jazzband / django-two-factor-auth

Complete Two-Factor Authentication for Django providing the easiest integration into most Django projects.

MIT License

1.71k stars 448 forks source link

Django >= 4.1 <5 wants a default form renderer #552

Closed jpaniagualaconich closed 2 years ago

jpaniagualaconich commented 2 years ago

If not set, automated testing output gets cluttered with deprecation warnings.

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

codecov[bot] commented 2 years ago

Codecov Report

Merging #552 (e203292) into master (c086b7f) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #552   +/-   ##
=======================================
  Coverage   87.63%   87.63%           
=======================================
  Files          65       65           
  Lines        2862     2862           
  Branches      261      261           
=======================================
  Hits         2508     2508           
  Misses        337      337           
  Partials       17       17

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

claudep commented 2 years ago

Most deprecation warnings come from django-formtools. I tried to fix this in django-formtools and hope a 2.4 release will be made soon, then I'd like to rerun the tests with an updated django-formtools to see if this PR is still needed or not.

claudep commented 2 years ago

django-formtools 2.4 was released today. Together with the changes of #555, this patch should no longer be necessary. Thanks anyway!