jazzband / django-two-factor-auth

Complete Two-Factor Authentication for Django providing the easiest integration into most Django projects.
MIT License
1.71k stars 448 forks source link

bump up selenium version to fix unclosed socket warning #553

Closed jpaniagualaconich closed 2 years ago

jpaniagualaconich commented 2 years ago

Description

Motivation and Context

Running the test in two_factor.plugins.webauthn.tests.test_e2e produces a warning:

sys:1: ResourceWarning: unclosed <socket.socket fd=4, family=AddressFamily.AF_INET, type=SocketKind.SOCK_STREAM, proto=6, laddr=('127.0.0.1', 48018), raddr=('127.0.0.1', 51269)>

Newer Selenium fixes this.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

codecov[bot] commented 2 years ago

Codecov Report

Merging #553 (848a223) into master (c086b7f) will increase coverage by 10.52%. The diff coverage is n/a.

@@             Coverage Diff             @@
##           master     #553       +/-   ##
===========================================
+ Coverage   87.63%   98.15%   +10.52%     
===========================================
  Files          65       65               
  Lines        2862     2926       +64     
  Branches      261      261               
===========================================
+ Hits         2508     2872      +364     
+ Misses        337       30      -307     
- Partials       17       24        +7     
Impacted Files Coverage Δ
tests/test_admin.py 100.00% <0.00%> (ø)
tests/test_email.py 100.00% <0.00%> (ø)
tests/test_utils.py 100.00% <0.00%> (ø)
tests/test_yubikey.py 100.00% <0.00%> (ø)
tests/test_gateways.py 100.00% <0.00%> (ø)
tests/test_views_login.py 100.00% <0.00%> (ø)
tests/test_views_phone.py 100.00% <0.00%> (ø)
tests/test_views_setup.py 100.00% <0.00%> (ø)
tests/test_views_mixins.py 100.00% <0.00%> (ø)
tests/test_views_qrcode.py 100.00% <0.00%> (ø)
... and 17 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more