search

jazzband / django-two-factor-auth

Complete Two-Factor Authentication for Django providing the easiest integration into most Django projects.
MIT License
1.71k stars 448 forks source link

Remove salted_hmac_sha256 #601

Closed sevdog closed 1 year ago

sevdog commented 1 year ago

Since now the minimun supported django version is 3.2 https://github.com/jazzband/django-two-factor-auth/blob/52b78a72fbfdeb356cadbc8faf23ac65a2141cc7/setup.py#L15

It does not make sense to keep this backported method and not use django salted_hmac instead.

https://github.com/jazzband/django-two-factor-auth/blob/52b78a72fbfdeb356cadbc8faf23ac65a2141cc7/two_factor/views/utils.py#L303-L310

claudep commented 1 year ago

Good catch, do you plan to suggest a pull request?

sevdog commented 1 year ago

@claudep I can provide a PR with this with ease.